HDDS-13774. [Recon] Consolidate NSSummary endpoint tests into one suite#10769
Merged
Conversation
priyeshkaratha
marked this pull request as ready for review
July 15, 2026 02:11
devmadhuu
self-requested a review
July 22, 2026 14:57
devmadhuu
approved these changes
Jul 22, 2026
devmadhuu
left a comment
devmadhuu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @priyeshkaratha for the patch. Changes LGTM +1
Member
Author
|
Thanks @devmadhuu for reviewing the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The NSSummary REST API had three near-duplicate test classes TestNSSummaryEndpointWith{FSO,Legacy,OBSAndLegacy} (~4,500 lines). This replaces them with a single @ParameterizedClass suite (TestNSSummaryEndpoint) driven by per-layout scenario objects, sharing all constants, fixtures, and assertions.
Multi-block keys now use genuine RATIS/THREE replication; replication tests assert sizeWithReplica (3×) and raw size against independent constants.
What is the link to the Apache JIRA
HDDS-13774
How was this patch tested?
TestNSSummaryEndpoint: 117 run, 0 failures. checkstyle.sh and rat.sh clean
Generated-by: Claude Code (Opus 4.8)